Change ProductOfSets to remove dependence on implementation in MOI#372
Change ProductOfSets to remove dependence on implementation in MOI#372odow wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #372 +/- ##
==========================================
- Coverage 91.88% 91.46% -0.42%
==========================================
Files 17 17
Lines 2722 2788 +66
==========================================
+ Hits 2501 2550 +49
- Misses 221 238 +17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Can the ProductOfSets in DiffOpt be simplified to be able to reuse against the implementation of the MOI one ? Actually, I always wanted to move this ProductOfSets of DiffOpt to MOI, it is also useful for MatrixOfConstraints and would be for any MOI model that can support arbitrary sets. Maybe we can move it to MOI first and then do jump-dev/MathOptInterface.jl#3022 |
|
Maybe one required step is to compat bound DiffOpt in the registry. Then we can make changes to MOI. And then we can make changes to DiffOpt. I'd actually be in favor of making the types in MOI settable at runtime. I don't think we gain much by having them set by the macro. |
2 participants
I wanted to update MOI (jump-dev/MathOptInterface.jl#3022), but this part of DiffOpt depends on the internal fields.
The change to MOI is theoretically breaking (as evidenced by the need for this PR), so that is a draft for discussion. We might never merge the change in MOI, but this change could be merged regardless.